-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[master] Debian/RedHat systemd: MemoryLimit -> MemoryMax #5589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
MemoryMax has been introduced with systemd 231 MemoryLimit has been marked deprecated with systemd 252
|
This avoids a warning like this one (on Debian 12, using systemd 231) # systemd-analyze verify /lib/systemd/system/freeradius.service
/lib/systemd/system/freeradius.service:23: Unit uses MemoryLimit=; please use MemoryMax= instead. Support for MemoryLimit= will be removed soon.``` |
MemoryMax has been introduced with systemd 231 and MemoryLimit has been marked deprecated with systemd 252. EL 7 is past its regular support cycle for some time now and EL 8 already ships with systemd 239. Thus it should be safe to switch to this more modern option for a future release.
|
Is there any change in behaviour? Or the systemd guys just like renaming things to keep people on their toes? |
|
As well as potential change of behaviour, this also needs checking that it doesn't break any of the older Debian-based distros as they are all built using the same source. |
|
@arr2036: It seems to be related to this info in the v252 release of systemd and them dropping cgroupsv1 at some point as described in the "history" section of Considering that (likely) until 4.x gets released, very old distributions based of Debian or RHEL are likely long gone, but for 3.2 it might be worth to do some more checking. @mcnewton : For what I can see on Debian 12, it's pretty much a drop-in replacement, but I agree with you, that it needs proper checking. There is one other example I found from a package from Red Hat where they updated it for RHEL 9 in How distributions using the InkBridge repositories might be affectedInkBridge Networks builds FreeRADIUS packages for RHEL- and Debian-based distributions from this repository, but "only" for the 3.0 & 3.2 releases, not for master or the upcoming 4.x version so these shouldn't be affected IMO. (BTW: Thank you for this service!) Debian-based distributions
(RH)EL-based distributions |
|
Should I update the to only change the behaviour for Debian? The reasoning is, that since the initial PR things have changed as follows: |
Why the change?
Thoughts based on the systemd version shipped with Debian and RHEL distributions: